schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #40937 from frappe/mergify/bp/version-14-hotfix/pr-40936

Browse Source 
fix: ignore dimension validation for cancelled entries (backport #40936)
This commit is contained in:
ruthra kumar
2024-04-10 15:28:00 +05:30
committed by GitHub
parent a31b2e17f5 9745724d41
commit 73d2595aa6
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/accounts/doctype/gl_entry/gl_entry.py
View File

@@ -135,6 +135,7 @@ class GLEntry(Document):
and self.company == dimension.company and self.company == dimension.company
and dimension.mandatory_for_pl and dimension.mandatory_for_pl
and not dimension.disabled and not dimension.disabled
and not self.is_cancelled
): ):
if not self.get(dimension.fieldname): if not self.get(dimension.fieldname):
frappe.throw( frappe.throw(
@@ -148,6 +149,7 @@ class GLEntry(Document):
and self.company == dimension.company and self.company == dimension.company
and dimension.mandatory_for_bs and dimension.mandatory_for_bs
and not dimension.disabled and not dimension.disabled
and not self.is_cancelled
): ):
if not self.get(dimension.fieldname): if not self.get(dimension.fieldname):
frappe.throw( frappe.throw(