schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Remove unnecessary list comprehensions

Browse Source
This commit is contained in:
Rucha Mahabal
2022-07-18 21:32:04 +05:30
parent abb7ac5a0b
commit 711501be5e
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
erpnext/hr/doctype/shift_type/shift_type.py
View File

@@ -156,21 +156,19 @@ class ShiftType(Document):
if not from_date: if not from_date:
del filters["start_date"] del filters["start_date"]
assigned_employees = frappe.get_all("Shift Assignment", "employee", filters, as_list=True) assigned_employees = frappe.get_all("Shift Assignment", filters, pluck="employee")
assigned_employees = [x[0] for x in assigned_employees]
if consider_default_shift: if consider_default_shift:
filters = {"default_shift": self.name, "status": ["!=", "Inactive"]} filters = {"default_shift": self.name, "status": ["!=", "Inactive"]}
default_shift_employees = frappe.get_all("Employee", "name", filters, as_list=True) default_shift_employees = frappe.get_all("Employee", filters, pluck="name")
default_shift_employees = [x[0] for x in default_shift_employees]
return list(set(assigned_employees + default_shift_employees)) return list(set(assigned_employees + default_shift_employees))
return assigned_employees return assigned_employees
def process_auto_attendance_for_all_shifts(): def process_auto_attendance_for_all_shifts():
shift_list = frappe.get_all("Shift Type", "name", {"enable_auto_attendance": "1"}, as_list=True) shift_list = frappe.get_all("Shift Type", filters={"enable_auto_attendance": "1"}, pluck="name")
for shift in shift_list: for shift in shift_list:
doc = frappe.get_doc("Shift Type", shift[0]) doc = frappe.get_doc("Shift Type", shift)
doc.process_auto_attendance() doc.process_auto_attendance()