From 64b646050e7ead6cc90afa1b5bed347c93410cb2 Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Wed, 16 Mar 2022 19:51:22 +0530 Subject: [PATCH] refactor: removed unrequired code and test for standalone delivery note serial return (#30276) (#30278) (cherry picked from commit 2a0ca7c91a8f788e765d7465b82e9f6238960d4a) Co-authored-by: Noah Jacob --- erpnext/stock/doctype/delivery_note/delivery_note.py | 8 +------- erpnext/stock/doctype/delivery_note/test_delivery_note.py | 5 ----- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/erpnext/stock/doctype/delivery_note/delivery_note.py b/erpnext/stock/doctype/delivery_note/delivery_note.py index b10a7015dec..93d2357cfa9 100644 --- a/erpnext/stock/doctype/delivery_note/delivery_note.py +++ b/erpnext/stock/doctype/delivery_note/delivery_note.py @@ -13,10 +13,7 @@ from frappe.utils import cint, flt from erpnext.controllers.accounts_controller import get_taxes_and_charges from erpnext.controllers.selling_controller import SellingController from erpnext.stock.doctype.batch.batch import set_batch_nos -from erpnext.stock.doctype.serial_no.serial_no import ( - get_delivery_note_serial_no, - update_serial_nos_after_submit, -) +from erpnext.stock.doctype.serial_no.serial_no import get_delivery_note_serial_no form_grid_templates = { "items": "templates/form_grid/item_grid.html" @@ -218,9 +215,6 @@ class DeliveryNote(SellingController): # Updating stock ledger should always be called after updating prevdoc status, # because updating reserved qty in bin depends upon updated delivered qty in SO self.update_stock_ledger() - if self.is_return: - update_serial_nos_after_submit(self, "items") - self.make_gl_entries() self.repost_future_sle_and_gle() diff --git a/erpnext/stock/doctype/delivery_note/test_delivery_note.py b/erpnext/stock/doctype/delivery_note/test_delivery_note.py index 9dc112fda85..82f4e7dd294 100644 --- a/erpnext/stock/doctype/delivery_note/test_delivery_note.py +++ b/erpnext/stock/doctype/delivery_note/test_delivery_note.py @@ -823,11 +823,6 @@ class TestDeliveryNote(FrappeTestCase): automatically_fetch_payment_terms(enable=0) - def test_standalone_serial_no_return(self): - dn = create_delivery_note(item_code="_Test Serialized Item With Series", is_return=True, qty=-1) - dn.reload() - self.assertTrue(dn.items[0].serial_no) - def create_delivery_note(**args): dn = frappe.new_doc("Delivery Note") args = frappe._dict(args)