fix codacy

2018-05-07 16:55:32 +05:30
parent bbd8508783
commit 64614374d8
4 changed files with 29 additions and 30 deletions
--- a/erpnext/controllers/selling_controller.py
+++ b/erpnext/controllers/selling_controller.py
@@ -352,10 +352,10 @@ def check_active_sales_items(obj):
 					if default.company == obj.company:
 						default.income_account = d.income_account
 						income_account_set = True
-				else:
-					if not income_account_set:
-						doc.append("item_defaults", {
-							"company": obj.company,
-							"income_account": d.income_account
-						})
+						break
+				if not income_account_set:
+					doc.append("item_defaults", {
+						"company": obj.company,
+						"income_account": d.income_account
+					})
 				doc.save()