From 5319683dbf2ec2e9fb4727cf6e9dd90767f06252 Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Tue, 4 Feb 2025 13:18:44 +0530 Subject: [PATCH] fix: subcontracting valiation precision issue (cherry picked from commit 8720d412bdfe584b98ebba785800691ded15e3f9) --- erpnext/controllers/subcontracting_controller.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/erpnext/controllers/subcontracting_controller.py b/erpnext/controllers/subcontracting_controller.py index 349a15703fb..b6a7f715d22 100644 --- a/erpnext/controllers/subcontracting_controller.py +++ b/erpnext/controllers/subcontracting_controller.py @@ -113,11 +113,10 @@ class SubcontractingController(StockController): ) item.sc_conversion_factor = service_item_qty / item.qty - if ( - self.doctype not in "Subcontracting Receipt" - and item.qty - > flt(get_pending_sco_qty(self.purchase_order).get(item.purchase_order_item)) - / item.sc_conversion_factor + if self.doctype not in "Subcontracting Receipt" and item.qty > flt( + get_pending_sco_qty(self.purchase_order).get(item.purchase_order_item) + / item.sc_conversion_factor, + frappe.get_precision("Purchase Order Item", "qty"), ): frappe.throw( _(