schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: group item reorder by (warehouse, material_request_type) (backport #35818) (#36425)

Browse Source 
fix: group item reorder by (warehouse, material_request_type) (#35818)

* fix: group item reorder by (warehouse, material_request_type)

* fix: update reorder error message

* chore: linter

* fix: correct error message

Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>

* chore: linter

---------

Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
(cherry picked from commit e8eeeb16e2)

Co-authored-by: Devin Slauenwhite <devin.slauenwhite@gmail.com>
This commit is contained in:
mergify[bot]
2023-07-31 18:36:09 +05:30
committed by GitHub
parent 33a947726d
commit 516191bf2b
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
erpnext/stock/doctype/item/item.py
View File

@@ -395,16 +395,16 @@ class Item(Document):
def validate_warehouse_for_reorder(self): def validate_warehouse_for_reorder(self):
"""Validate Reorder level table for duplicate and conditional mandatory""" """Validate Reorder level table for duplicate and conditional mandatory"""
warehouse = [] warehouse_material_request_type: list[tuple[str, str]] = []
for d in self.get("reorder_levels"): for d in self.get("reorder_levels"):
if not d.warehouse_group: if not d.warehouse_group:
d.warehouse_group = d.warehouse d.warehouse_group = d.warehouse
if d.get("warehouse") and d.get("warehouse") not in warehouse: if (d.get("warehouse"), d.get("material_request_type")) not in warehouse_material_request_type:
warehouse += [d.get("warehouse")] warehouse_material_request_type += [(d.get("warehouse"), d.get("material_request_type"))]
else: else:
frappe.throw( frappe.throw(
_("Row {0}: An Reorder entry already exists for this warehouse {1}").format( _("Row #{0}: A reorder entry already exists for warehouse {1} with reorder type {2}.").format(
d.idx, d.warehouse d.idx, d.warehouse, d.material_request_type
), ),
DuplicateReorderRows, DuplicateReorderRows,
) )