From 518dad8ecba61acd80ce6eb0bd3e050b0f585024 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Wed, 17 Apr 2024 12:49:01 +0530 Subject: [PATCH 1/2] ci: dont auto apply fixes I've personally encountered ~5 instances of bad auto fixes, let developers apply the fixes. (cherry picked from commit 3b4913ec810bcee60537380bdc721c04a4e823c6) --- .pre-commit-config.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 1f670f2bec3..14bd9e8f0c4 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -69,8 +69,7 @@ repos: rev: v0.2.0 hooks: - id: ruff - name: "Run ruff linter and apply fixes" - args: ["--fix"] + name: "Run ruff linter" - id: ruff-format name: "Format Python code" From 76b7884fb7a8d60e1282f58e652b73f597439bce Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Tue, 21 May 2024 16:05:16 +0530 Subject: [PATCH 2/2] ci: ruff only fix imports (cherry picked from commit 85b1a8001b30429800ca5c6bef960c885368819b) --- .pre-commit-config.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 14bd9e8f0c4..56bcb22c9bb 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -68,12 +68,15 @@ repos: - repo: https://github.com/astral-sh/ruff-pre-commit rev: v0.2.0 hooks: + - id: ruff + name: "Run ruff import sorter" + args: ["--select=I", "--fix"] + - id: ruff name: "Run ruff linter" - id: ruff-format - name: "Format Python code" - + name: "Run ruff formatter" ci: autoupdate_schedule: weekly