schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(treewide): formatting and ruff fixes, + manually enabled F401

Browse Source 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
This commit is contained in:
Akhil Narang
2024-03-27 11:37:26 +05:30
parent c28d19cf7f
commit 4d34b1ead7
618 changed files with 4188 additions and 6384 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
erpnext/utilities/naming.py
View File

@@ -6,9 +6,7 @@ class NamingSeriesNotSetError(frappe.ValidationError):
pass
def set_by_naming_series(
doctype, fieldname, naming_series, hide_name_field=True, make_mandatory=1
):
def set_by_naming_series(doctype, fieldname, naming_series, hide_name_field=True, make_mandatory=1):
"""Change a doctype's naming to user naming series"""
from frappe.custom.doctype.property_setter.property_setter import make_property_setter
@@ -24,9 +22,7 @@ def set_by_naming_series(
try:
frappe.db.sql(
"""update `tab{doctype}` set naming_series={s} where
ifnull(naming_series, '')=''""".format(
doctype=doctype, s="%s"
),
ifnull(naming_series, '')=''""".format(doctype=doctype, s="%s"),
get_default_naming_series(doctype),
)
except NamingSeriesNotSetError:
@@ -34,27 +30,19 @@ def set_by_naming_series(
if hide_name_field:
make_property_setter(doctype, fieldname, "reqd", 0, "Check", validate_fields_for_doctype=False)
make_property_setter(
doctype, fieldname, "hidden", 1, "Check", validate_fields_for_doctype=False
)
make_property_setter(doctype, fieldname, "hidden", 1, "Check", validate_fields_for_doctype=False)
else:
make_property_setter(
doctype, "naming_series", "reqd", 0, "Check", validate_fields_for_doctype=False
)
make_property_setter(doctype, "naming_series", "reqd", 0, "Check", validate_fields_for_doctype=False)
make_property_setter(
doctype, "naming_series", "hidden", 1, "Check", validate_fields_for_doctype=False
)
if hide_name_field:
make_property_setter(
doctype, fieldname, "hidden", 0, "Check", validate_fields_for_doctype=False
)
make_property_setter(doctype, fieldname, "hidden", 0, "Check", validate_fields_for_doctype=False)
make_property_setter(doctype, fieldname, "reqd", 1, "Check", validate_fields_for_doctype=False)
# set values for mandatory
frappe.db.sql(
"""update `tab{doctype}` set `{fieldname}`=`name` where
ifnull({fieldname}, '')=''""".format(
doctype=doctype, fieldname=fieldname
)
f"""update `tab{doctype}` set `{fieldname}`=`name` where
ifnull({fieldname}, '')=''"""
)