schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #33734 from frappe/mergify/bp/version-13-hotfix/pr-33619

Browse Source 
fix: rewrite logic for duplicate check in Item Attribute (backport #33619)
This commit is contained in:
Sagar Sharma
2023-01-19 15:29:17 +05:30
committed by GitHub
parent f2d83b1b21 13906cba9a
commit 40ab5b034c
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
erpnext/stock/doctype/item_attribute/item_attribute.py
View File

@@ -74,11 +74,10 @@ class ItemAttribute(Document):
def validate_duplication(self): def validate_duplication(self):
values, abbrs = [], [] values, abbrs = [], []
for d in self.item_attribute_values: for d in self.item_attribute_values:
d.abbr = d.abbr.upper() if d.attribute_value.lower() in map(str.lower, values):
if d.attribute_value in values: frappe.throw(_("Attribute value: {0} must appear only once").format(d.attribute_value.title()))
frappe.throw(_("{0} must appear only once").format(d.attribute_value))
values.append(d.attribute_value) values.append(d.attribute_value)
if d.abbr in abbrs: if d.abbr.lower() in map(str.lower, abbrs):
frappe.throw(_("{0} must appear only once").format(d.abbr)) frappe.throw(_("Abbreviation: {0} must appear only once").format(d.abbr.title()))
abbrs.append(d.abbr) abbrs.append(d.abbr)