From 401fd7fca7966bc2719ab0174b50d238f0b6d5ae Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Tue, 4 Feb 2025 17:50:26 +0530 Subject: [PATCH] fix: semgrep (cherry picked from commit ffd10d1fe95bc85485be90cb6a2bbbb04d5bf690) --- erpnext/controllers/stock_controller.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/erpnext/controllers/stock_controller.py b/erpnext/controllers/stock_controller.py index 9dfaae7188e..5ff03eb0a51 100644 --- a/erpnext/controllers/stock_controller.py +++ b/erpnext/controllers/stock_controller.py @@ -1580,9 +1580,12 @@ def check_item_quality_inspection(doctype, items): "Delivery Note": "inspection_required_before_delivery", } + items_to_remove = [] for item in items: if not frappe.db.get_value("Item", item.get("item_code"), inspection_fieldname_map.get(doctype)): - items.remove(item) + items_to_remove.append(item) + items = [item for item in items if item not in items_to_remove] + return items