schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: update variable names for improved readability

Browse Source
This commit is contained in:
Sugesh393
2025-01-21 17:38:24 +05:30
parent 454067198e
commit 36bae55299
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
erpnext/controllers/accounts_controller.py
View File

@@ -411,7 +411,7 @@ class AccountsController(TransactionBase):
def validate_company_in_accounting_dimension(self): def validate_company_in_accounting_dimension(self):
doc_field = DocType("DocField") doc_field = DocType("DocField")
accounting_dimension = DocType("Accounting Dimension") accounting_dimension = DocType("Accounting Dimension")
query = ( dimension_list = (
frappe.qb.from_(accounting_dimension) frappe.qb.from_(accounting_dimension)
.select(accounting_dimension.document_type) .select(accounting_dimension.document_type)
.join(doc_field) .join(doc_field)
@@ -419,12 +419,11 @@ class AccountsController(TransactionBase):
.where(doc_field.fieldname == "company") .where(doc_field.fieldname == "company")
).run(as_list=True) ).run(as_list=True)
dimension_list = sum(query, ["Project"]) dimension_list = sum(dimension_list, ["Project"])
self.validate_company(dimension_list) self.validate_company(dimension_list)
if childs := self.get_all_children(): for child in self.get_all_children() or []:
for child in childs: self.validate_company(dimension_list, child)
self.validate_company(dimension_list, child)
def validate_company(self, dimension_list, child=None): def validate_company(self, dimension_list, child=None):
for dimension in dimension_list: for dimension in dimension_list: