From 1d81a9f9333f96fd7a252d870afa8f121dd7c0e7 Mon Sep 17 00:00:00 2001 From: mahsem <137205921+mahsem@users.noreply.github.com> Date: Sun, 19 Jan 2025 20:52:58 +0100 Subject: [PATCH 1/2] fix: translation fixes --- .../accounts/doctype/accounts_settings/accounts_settings.js | 2 +- .../doctype/plaid_settings/plaid_settings.js | 2 +- erpnext/manufacturing/doctype/bom_creator/bom_creator.py | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/erpnext/accounts/doctype/accounts_settings/accounts_settings.js b/erpnext/accounts/doctype/accounts_settings/accounts_settings.js index 4f59085db0a..95332acdc28 100644 --- a/erpnext/accounts/doctype/accounts_settings/accounts_settings.js +++ b/erpnext/accounts/doctype/accounts_settings/accounts_settings.js @@ -12,7 +12,7 @@ frappe.ui.form.on("Accounts Settings", { msg += " "; msg += __("Please enable only if the understand the effects of enabling this."); msg += "
"; - msg += "Do you still want to enable immutable ledger?"; + msg += __("Do you still want to enable immutable ledger?"); frappe.confirm( msg, diff --git a/erpnext/erpnext_integrations/doctype/plaid_settings/plaid_settings.js b/erpnext/erpnext_integrations/doctype/plaid_settings/plaid_settings.js index 3c72f2cbab5..04215e92234 100644 --- a/erpnext/erpnext_integrations/doctype/plaid_settings/plaid_settings.js +++ b/erpnext/erpnext_integrations/doctype/plaid_settings/plaid_settings.js @@ -29,7 +29,7 @@ frappe.ui.form.on("Plaid Settings", { "Bank Transaction", "", true, - "Bank Transaction" + __("Bank Transaction") ); frappe.msgprint({ diff --git a/erpnext/manufacturing/doctype/bom_creator/bom_creator.py b/erpnext/manufacturing/doctype/bom_creator/bom_creator.py index 59f8fb8178c..2ca29804a20 100644 --- a/erpnext/manufacturing/doctype/bom_creator/bom_creator.py +++ b/erpnext/manufacturing/doctype/bom_creator/bom_creator.py @@ -206,7 +206,9 @@ class BOMCreator(Document): for field, label in fields.items(): if not self.get(field): - frappe.throw(_("Please set {0} in BOM Creator {1}").format(label, self.name)) + frappe.throw( + _("Please set {0} in BOM Creator {1}").format(_(label), self.name) + ) def on_submit(self): self.enqueue_create_boms() From 3697ba0772c0e5479ac6951bdb0c14926610837a Mon Sep 17 00:00:00 2001 From: mahsem <137205921+mahsem@users.noreply.github.com> Date: Sun, 19 Jan 2025 21:00:02 +0100 Subject: [PATCH 2/2] fix: linters --- erpnext/manufacturing/doctype/bom_creator/bom_creator.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/erpnext/manufacturing/doctype/bom_creator/bom_creator.py b/erpnext/manufacturing/doctype/bom_creator/bom_creator.py index 2ca29804a20..41363120a5f 100644 --- a/erpnext/manufacturing/doctype/bom_creator/bom_creator.py +++ b/erpnext/manufacturing/doctype/bom_creator/bom_creator.py @@ -206,9 +206,7 @@ class BOMCreator(Document): for field, label in fields.items(): if not self.get(field): - frappe.throw( - _("Please set {0} in BOM Creator {1}").format(_(label), self.name) - ) + frappe.throw(_("Please set {0} in BOM Creator {1}").format(_(label), self.name)) def on_submit(self): self.enqueue_create_boms()