From 289694ed4caa8ba0cc1955f38a191b1009f0f14b Mon Sep 17 00:00:00 2001 From: ruthra kumar Date: Mon, 23 Jun 2025 17:09:29 +0530 Subject: [PATCH] chore: resolve linter --- .../payment_reconciliation/test_payment_reconciliation.py | 4 +++- erpnext/controllers/accounts_controller.py | 1 - erpnext/controllers/sales_and_purchase_return.py | 4 +--- erpnext/stock/doctype/packing_slip/packing_slip.py | 7 +++++-- .../doctype/purchase_receipt/test_purchase_receipt.py | 2 +- 5 files changed, 10 insertions(+), 8 deletions(-) diff --git a/erpnext/accounts/doctype/payment_reconciliation/test_payment_reconciliation.py b/erpnext/accounts/doctype/payment_reconciliation/test_payment_reconciliation.py index ab61b85e710..57231ec5bdd 100644 --- a/erpnext/accounts/doctype/payment_reconciliation/test_payment_reconciliation.py +++ b/erpnext/accounts/doctype/payment_reconciliation/test_payment_reconciliation.py @@ -1979,7 +1979,9 @@ class TestPaymentReconciliation(IntegrationTestCase): def test_reconciliation_on_closed_period_payment(self): # create backdated fiscal year - first_fy_start_date = frappe.db.get_value("Fiscal Year", {"disabled": 0}, [{'MIN': 'year_start_date'}]) + first_fy_start_date = frappe.db.get_value( + "Fiscal Year", {"disabled": 0}, [{"MIN": "year_start_date"}] + ) prev_fy_start_date = add_years(first_fy_start_date, -1) prev_fy_end_date = add_days(first_fy_start_date, -1) create_fiscal_year( diff --git a/erpnext/controllers/accounts_controller.py b/erpnext/controllers/accounts_controller.py index 20d8079d648..bb918934a01 100644 --- a/erpnext/controllers/accounts_controller.py +++ b/erpnext/controllers/accounts_controller.py @@ -2232,7 +2232,6 @@ class AccountsController(TransactionBase): def set_advance_payment_status(self): new_status = None - PaymentRequest = frappe.qb.DocType("Payment Request") paid_amount = frappe.get_value( doctype="Payment Request", diff --git a/erpnext/controllers/sales_and_purchase_return.py b/erpnext/controllers/sales_and_purchase_return.py index e5864ce13ad..0a221d9d2c6 100644 --- a/erpnext/controllers/sales_and_purchase_return.py +++ b/erpnext/controllers/sales_and_purchase_return.py @@ -663,9 +663,7 @@ def get_rate_for_return( select_field = "incoming_rate" else: StockLedgerEntry = frappe.qb.DocType("Stock Ledger Entry") - select_field = Abs( - StockLedgerEntry.stock_value_difference / StockLedgerEntry.actual_qty - ) + select_field = Abs(StockLedgerEntry.stock_value_difference / StockLedgerEntry.actual_qty) rate = flt(frappe.db.get_value("Stock Ledger Entry", filters, select_field)) if not (rate and return_against) and voucher_type in ["Sales Invoice", "Delivery Note"]: diff --git a/erpnext/stock/doctype/packing_slip/packing_slip.py b/erpnext/stock/doctype/packing_slip/packing_slip.py index c30645f8827..587d7ecd337 100644 --- a/erpnext/stock/doctype/packing_slip/packing_slip.py +++ b/erpnext/stock/doctype/packing_slip/packing_slip.py @@ -4,8 +4,9 @@ import frappe from frappe import _ -from frappe.utils import cint, flt from frappe.query_builder.functions import Sum +from frappe.utils import cint, flt + from erpnext.controllers.status_updater import StatusUpdater @@ -174,7 +175,9 @@ class PackingSlip(StatusUpdater): return ( cint( frappe.db.get_value( - "Packing Slip", {"delivery_note": self.delivery_note, "docstatus": 1}, [{"MAX": "to_case_no"}] + "Packing Slip", + {"delivery_note": self.delivery_note, "docstatus": 1}, + [{"MAX": "to_case_no"}], ) ) + 1 diff --git a/erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py b/erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py index d1e9cd8766b..c96536d049a 100644 --- a/erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py +++ b/erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py @@ -2128,7 +2128,7 @@ class TestPurchaseReceipt(IntegrationTestCase): self.assertEqual(flt(pr.total * pr.conversion_rate, 2), flt(pr.base_total, 2)) # Test - 2: Sum of Debit or Credit should be equal to Purchase Receipt Base Total - amount = frappe.db.get_value("GL Entry", {"docstatus": 1, "voucher_no": pr.name}, [{'SUM': 'debit'}]) + amount = frappe.db.get_value("GL Entry", {"docstatus": 1, "voucher_no": pr.name}, [{"SUM": "debit"}]) expected_amount = pr.base_total self.assertEqual(amount, expected_amount)