schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: early return is always better

Browse Source 
validate_advance_entries() has a heavy IO bound operation. Early
return on unwanted cases is always better.
This commit is contained in:
ruthra kumar
2024-12-27 12:48:25 +05:30
parent e1fc239f3d
commit 0589fa7f3e
1 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
erpnext/controllers/accounts_controller.py
View File

@@ -477,6 +477,9 @@ class AccountsController(TransactionBase):
self.payment_terms_template = "" self.payment_terms_template = ""
self.payment_schedule = [] self.payment_schedule = []
if self.is_return:
return
self.validate_payment_schedule_dates() self.validate_payment_schedule_dates()
self.set_due_date() self.set_due_date()
self.set_payment_schedule() self.set_payment_schedule()
@@ -2374,6 +2377,9 @@ class AccountsController(TransactionBase):
dates = [] dates = []
li = [] li = []
if self.doctype == "Sales Invoice" and self.is_pos:
return
for d in self.get("payment_schedule"): for d in self.get("payment_schedule"):
d.validate_from_to_dates("discount_date", "due_date") d.validate_from_to_dates("discount_date", "due_date")
if self.doctype == "Sales Order" and getdate(d.due_date) < getdate(self.transaction_date): if self.doctype == "Sales Order" and getdate(d.due_date) < getdate(self.transaction_date):
@@ -2391,6 +2397,9 @@ class AccountsController(TransactionBase):
frappe.throw(_("Rows with duplicate due dates in other rows were found: {0}").format(duplicates)) frappe.throw(_("Rows with duplicate due dates in other rows were found: {0}").format(duplicates))
def validate_payment_schedule_amount(self): def validate_payment_schedule_amount(self):
if (self.doctype == "Sales Invoice" and self.is_pos) or self.get("is_opening") == "Yes":
return
party_account_currency = self.get("party_account_currency") party_account_currency = self.get("party_account_currency")
if not party_account_currency: if not party_account_currency:
party_type, party = self.get_party() party_type, party = self.get_party()