schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: unable to remove image from employee

Browse Source 
fix: employee image disappears when newly created user_id is linked to employee
This commit is contained in:
Asmita Hase
2025-02-07 17:27:44 +05:30
parent 88e68bb803
commit 0207d2d7b6
2 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/setup/doctype/employee/employee.json
View File

@@ -182,8 +182,6 @@
"read_only": 1 "read_only": 1
}, },
{ {
"fetch_from": "user_id.user_image",
"fetch_if_empty": 1,
"fieldname": "image", "fieldname": "image",
"fieldtype": "Attach Image", "fieldtype": "Attach Image",
"hidden": 1, "hidden": 1,
@@ -824,7 +822,7 @@
"image_field": "image", "image_field": "image",
"is_tree": 1, "is_tree": 1,
"links": [], "links": [],
"modified": "2024-03-27 13:09:36.900706", "modified": "2025-02-07 13:54:40.122345",
"modified_by": "Administrator", "modified_by": "Administrator",
"module": "Setup", "module": "Setup",
"name": "Employee", "name": "Employee",

4
erpnext/setup/doctype/employee/employee.py
View File

@@ -64,14 +64,12 @@ class Employee(NestedSet):
def validate_user_details(self): def validate_user_details(self):
if self.user_id: if self.user_id:
data = frappe.db.get_value("User", self.user_id, ["enabled", "user_image"], as_dict=1) data = frappe.db.get_value("User", self.user_id, ["enabled"], as_dict=1)
if not data: if not data:
self.user_id = None self.user_id = None
return return
if data.get("user_image") and self.image == "":
self.image = data.get("user_image")
self.validate_for_enabled_user_id(data.get("enabled", 0)) self.validate_for_enabled_user_id(data.get("enabled", 0))
self.validate_duplicate_user_id() self.validate_duplicate_user_id()