schuetz3/schuetz3-erpnext
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #33024 from frappe/mergify/bp/version-13-hotfix/pr-33019

Browse Source 
fix: use `list()` on self mutating iteration (backport #33019)
This commit is contained in:
Sagar Sharma
2022-11-18 10:59:54 +05:30
committed by GitHub
parent 357ae939d1 0070b5ef9a
commit 00f990e3f4
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/erpnext_integrations/taxjar_integration.py
View File

@@ -302,7 +302,7 @@ def check_for_nexus(doc, tax_dict):
item.tax_collectable = flt(0) item.tax_collectable = flt(0)
item.taxable_amount = flt(0) item.taxable_amount = flt(0)
for tax in doc.taxes: for tax in list(doc.taxes):
if tax.account_head == TAX_ACCOUNT_HEAD: if tax.account_head == TAX_ACCOUNT_HEAD:
doc.taxes.remove(tax) doc.taxes.remove(tax)
return return

2
erpnext/stock/report/stock_ledger/stock_ledger.py
View File

@@ -355,7 +355,7 @@ def get_opening_balance(filters, columns, sl_entries):
) )
# check if any SLEs are actually Opening Stock Reconciliation # check if any SLEs are actually Opening Stock Reconciliation
for sle in sl_entries: for sle in list(sl_entries):
if ( if (
sle.get("voucher_type") == "Stock Reconciliation" sle.get("voucher_type") == "Stock Reconciliation"
and sle.get("date").split()[0] == filters.from_date and sle.get("date").split()[0] == filters.from_date