fix(shipment): apply code review

2020-10-01 01:23:29 +00:00
parent 1c9410e5e8
commit 000494f548
22 changed files with 405 additions and 444 deletions
--- a/erpnext/erpnext_integrations/utils.py
+++ b/erpnext/erpnext_integrations/utils.py
@@ -68,6 +68,4 @@ def get_tracking_url(carrier, tracking_number):
 	url_reference = frappe.get_value('Parcel Service', carrier, 'url_reference')
 	if url_reference:
 		tracking_url = frappe.render_template(url_reference, {'tracking_number': tracking_number})
-		tracking_url_template =  '<a href="{{ tracking_url }}" target="_blank"><b>{{ _("Click here to Track Shipment") }}</a></b>'
-		tracking_url = frappe.render_template(tracking_url_template, {'tracking_url': tracking_url})
 	return tracking_url